Skip to content

Speed up golangci-lint #18809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

silverwind
Copy link
Member

WIP, testing a few things against CI here.

@silverwind silverwind marked this pull request as draft February 18, 2022 17:03
@silverwind
Copy link
Member Author

Not sure if this is going anywhere, all attemps so far only made it slower. Still it definitely still recurses into node_modules as seen by the intermittent errors described in #18803.

Maybe I need to strace it to confirm what its doing. I can only imagine this to be a bug in golangci-lint, and not something related to our config.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2022
@markkrj
Copy link

markkrj commented Feb 20, 2022

@silverwind couldn't something be made in code-batch-process.go for golangci-lint?

@silverwind
Copy link
Member Author

Maybe, but I prefer to keep it simply a CLI change.

I don't think this PR as any value currently, closing.

@silverwind silverwind closed this Feb 26, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants