golangci-lint should ignore node_modules

[silverwind]

CI failure seen on https://drone.gitea.io/go-gitea/gitea/51286/1/6

It seems golangi-lint tries to access files in node_modules which is completely unnecessary and likely a reason for its long runtime. It might be possible to pass a list of files to it via golangci/golangci-lint#301 (comment), thought I'm not sure whether that usage actually works (golangci/golangci-lint#2568).

I recently added the skip-dirs option at

gitea/.golangci.yml

Lines 27 to 30 in 1ab88da

	skip-dirs:
	- node_modules
	- public
	- web_src

but it does not seem to help because not all of their "linters" seem to honour the option (golangci/golangci-lint#913).

[lunny]

So maybe we could run backend lint before frontend lint in CI to avoid that?

[silverwind]

That sounds like a workaround that will only work on CI. It needs to work locally too. Also, generally we want to run frontend/backend targets in parallel so folder absence can not be guaranteed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[lunny]

I think this has been resolved. If it's not, please feel free to reopen it.

[zeripath]

Fixed by #18708

[silverwind]

Not really fixed with that, skip-dirs only has effect on some linters, and those rare CI failures should still be able to happen currently.

[taagomag]

So is there any solution to skip node_modules? It seems that this issue is turning in circles since 2 years 😂

[silverwind]

No, it needs to happen in golang first: golang/go#42965.