Skip to content

Pass correct context #18638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2022
Merged

Pass correct context #18638

merged 1 commit into from
Feb 6, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Feb 6, 2022

Pass correct context
7d93dd2 
- Pass the correct context into `db.GetEngine()`.
- Introduced in: go-gitea#18604
@Gusted Gusted added this to the 1.17.0 milestone Feb 6, 2022
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 6, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ce8eb20). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18638   +/-   ##
=======================================
  Coverage        ?   46.32%           
=======================================
  Files           ?      846           
  Lines           ?   121236           
  Branches        ?        0           
=======================================
  Hits            ?    56163           
  Misses          ?    58257           
  Partials        ?     6816
Impacted Files Coverage Δ
models/user/user.go 57.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8eb20...7d93dd2. Read the comment docs.

@zeripath zeripath merged commit 7a42e35 into go-gitea:main Feb 6, 2022
@Gusted Gusted deleted the correct-ctx branch February 6, 2022 12:10
@singuliere
Copy link
Contributor

Thanks for fixing my mistake.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Pass correct context (go-gitea#18638)
9413a5a 
- Pass the correct context into `db.GetEngine()`.
- Introduced in: go-gitea#18604
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gusted @codecov-commenter @singuliere @lunny @zeripath @GiteaBot