Skip to content

Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2022
Merged

Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) #18473

merged 2 commits into from
Jan 30, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 30, 2022 •
edited by zeripath
Loading

Backport #18472

  • Prevent NPE panic when the full compare url regex isn't matched
  • Allow the usage of a shorter sha1 being used.

Fix #18471

@Gusted Gusted added this to the 1.16.1 milestone Jan 30, 2022
@Gusted Gusted changed the title Don't panic & allow shorter sha1 (#18472) Don't panic & allow shorter sha1 on compare URL (#18472) Jan 30, 2022
@zeripath
Improve comment
41d8a66 
Co-authored-by: Andrew Thornton <[email protected]>
@zeripath zeripath changed the title Don't panic & allow shorter sha1 on compare URL (#18472) Prevent NPE on partial match of compare URL and allow short SHA1 compare urls (#18472) Jan 30, 2022
@zeripath zeripath changed the title Prevent NPE on partial match of compare URL and allow short SHA1 compare urls (#18472) Prevent NPE on partial match of compare URL and allow short SHA1 compare URLs (#18472) Jan 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 30, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2022
@lafriks lafriks merged commit d5027b6 into go-gitea:release/v1.16 Jan 30, 2022
zeripath
zeripath reviewed Jan 31, 2022
View reviewed changes
@Gusted Gusted deleted the backport-fix-markdown-error branch January 31, 2022 18:37
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/theme/markdown type/bug
Projects
None yet
Milestone
1.16.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @lafriks @zeripath @GiteaBot