Add numerical app version metric #18454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `NumAppVer` variable to store the app version numerically - Add new "version" metric, collector for Prometheus Resolves: #18061
Gusted
reviewed
Jan 29, 2022
GiteaBot
added
the
lgtm/need 2
Co-authored-by: Gusted <[email protected]>
|
Maintainers: Unfortunately, I've been forced to make this PR as part of an academic assignment. If this does not look like an acceptable solution to this issue, please just close the PR. I don't want to waste your time. On the other hand, if this does look to be on the right track, I'm willing to make any minor changes that are requested. |
6543
requested changes
Jan 29, 2022
There was a problem hiding this comment.
well as pointed out at #18454 (comment) would be the only hacky working solution - but prometheus do accept String metrics so we can just pas semversion as string - through add gitea version prometheus metrics makes no sence to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumAppVervariable to store the app version numericallyResolves: #18061