docs(code style): remove unnecessary section #18209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi Wu <[email protected]>
This comment has been minimized.
This comment has been minimized.
GiteaBot
added
the
lgtm/need 2
|
Maybe the text should be replaced by If I understand correctly, now |
6543
approved these changes
Jan 8, 2022
GiteaBot
added
lgtm/need 1
6543
requested changes
Jan 8, 2022
zeripath
approved these changes
Jan 8, 2022
GiteaBot
added
lgtm/done
|
@wxiaoguang Yes, golangci-lint include revive/misspell linter. |
techknowlogick
approved these changes
Jan 8, 2022
|
I think we should still mention |
That could be another PR. |
6543
approved these changes
Jan 11, 2022
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 12, 2022
* 'main' of https://github.com/go-gitea/gitea: [doc] https-setup: explain relative paths for {CERT,KEY}_FILE fields. (go-gitea#18244) chore: remove unnecessary section (go-gitea#18209) Fix purple color in suggested label colors (go-gitea#18241) Prevent NPE when viewing non-rendered files (go-gitea#18234)
|
I proposed a new PR Hopefully we can keep documents correct and up-dated. |
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Signed-off-by: Bo-Yi Wu <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #18145 (comment) @wxiaoguang comment.
Signed-off-by: Bo-Yi Wu [email protected]