Restore setting of ctx.Repo.Mirror #18205
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go-gitea#17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that attempting change mirror settings results in an NPE. This PR simply restores this. Either we should remove this field or, we should set it. At present it seems simplest to set it instead of going looking in the Data for the value although converting the context to a bag of things may be the correct approach in the future. Fix go-gitea#18204 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
the
issue/regression
Gusted
approved these changes
Jan 7, 2022
GiteaBot
added
the
lgtm/need 1
zpericic
approved these changes
Jan 7, 2022
This comment has been minimized.
This comment has been minimized.
lunny
approved these changes
Jan 8, 2022
GiteaBot
added
lgtm/done
zeripath
added
the
skip-changelog
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 8, 2022
* 'main' of https://github.com/go-gitea/gitea: Fix EasyMDE image paste bug during refactoring (go-gitea#18207) Sort locales according to their names (go-gitea#18211) Restore setting of ctx.Repo.Mirror (go-gitea#18205) [skip ci] Updated translations via Crowdin Show OAuth callback error message (go-gitea#18185)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
In go-gitea#17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that attempting change mirror settings results in an NPE. This PR simply restores this. Either we should remove this field or, we should set it. At present it seems simplest to set it instead of going looking in the Data for the value although converting the context to a bag of things may be the correct approach in the future. Fix go-gitea#18204 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17933 repoAssignment no longer sets the ctx.Repo.Mirror field meaning that
attempting change mirror settings results in an NPE. This PR simply restores this.
Either we should remove this field or, we should set it. At present it seems simplest
to set it instead of going looking in the Data for the value although converting the
context to a bag of things may be the correct approach in the future.
Fix #18204
Signed-off-by: Andrew Thornton [email protected]