Skip to content

Upgrade certmagic from v0.14.1 to v0.15.2 #18138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 1, 2022
Merged

Upgrade certmagic from v0.14.1 to v0.15.2 #18138

merged 6 commits into from
Jan 1, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 31, 2021

Fix #18119

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Dec 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021 •
edited
Loading

Codecov Report

Merging #18138 (cdb48f7) into main (25a290e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18138      +/-   ##
==========================================
- Coverage   45.04%   45.02%   -0.03%     
==========================================
  Files         825      825              
  Lines       91538    91507      -31     
==========================================
- Hits        41231    41198      -33     
- Misses      43723    43726       +3     
+ Partials     6584     6583       -1
Impacted Files Coverage Δ
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/lfs.go 23.96% <0.00%> (-3.14%) ⬇️
routers/web/repo/lfs.go 0.00% <0.00%> (ø)
modules/sync/status_pool.go 60.86% <0.00%> (-39.14%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-5.00%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/queue/workerpool.go 51.14% <0.00%> (-1.91%) ⬇️
services/pull/pull.go 42.51% <0.00%> (+0.40%) ⬆️
modules/queue/queue_bytefifo.go 59.88% <0.00%> (+0.59%) ⬆️
modules/log/event.go 62.50% <0.00%> (+1.85%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385dc6a...cdb48f7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2021
@zeripath zeripath added this to the 1.16.0 milestone Dec 31, 2021
@wxiaoguang wxiaoguang merged commit 549fd03 into go-gitea:main Jan 1, 2022
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf pushed a commit to wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf/gitea that referenced this pull request Jan 1, 2022
@lunny
Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138)
e9c9a35
@lunny lunny deleted the lunny/upgrade_certmanager branch January 1, 2022 10:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 4, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
6cd8019 
* giteaoffical/main: (22 commits)
  Add MP4 as default allowed attachment type (go-gitea#18170)
  [skip ci] Updated translations via Crowdin
  Include folders into size cost (go-gitea#18158)
  Don't delete branch if other PRs with this branch are open (go-gitea#18164)
  Remove unused route "/tasks/trigger" (go-gitea#18160)
  Fix EasyMDE validation (go-gitea#18161)
  Fix bug (go-gitea#18168)
  tests: add coverage for models migration helpers  (go-gitea#18162)
  [skip ci] Updated translations via Crowdin
  Require codereview to have content (go-gitea#18156)
  chore(lint): use golangci-lint to call revive and misspell checker. (go-gitea#18145)
  Update owners for 2022 (go-gitea#18155)
  Refactor auth package (go-gitea#17962)
  Unify and simplify TrN for i18n (go-gitea#18141)
  Use correct user when determining max repo limits for error messages (go-gitea#18153)
  Add singuliere to MAINTAINERS (go-gitea#18148)
  [skip ci] Updated licenses and gitignores
  Add API to get issue/pull comments and events (timeline) (go-gitea#17403)
  Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138)
  Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138)
  ...
@techknowlogick techknowlogick mentioned this pull request Jan 17, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138)
fffbafd
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Upgrade certmagic from v0.14.1 to v0.15.2 (go-gitea#18138)
a718b99
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

certmagic : Change ManageSync() to take a context
6 participants
@lunny @codecov-commenter @zeripath @wxiaoguang @GiteaBot @6543