Skip to content

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Nov 20, 2021

During login reset the user's locale to ensure that it matches their
preferred locale.

Fix #15612

Signed-off-by: Andrew Thornton [email protected]

When logging in reset the user's locale to ensure that it matches their
preferred locale.

Fix go-gitea#15612

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.16.0 milestone Nov 20, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f8ec43d). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17734   +/-   ##
=======================================
  Coverage        ?   45.51%           
=======================================
  Files           ?      807           
  Lines           ?    89830           
  Branches        ?        0           
=======================================
  Hits            ?    40887           
  Misses          ?    42402           
  Partials        ?     6541           
Impacted Files Coverage Δ
routers/web/user/auth.go 12.06% <0.00%> (ø)
modules/context/api.go 74.41% <100.00%> (ø)
modules/context/context.go 61.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ec43d...fcc2c10. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2021
@wxiaoguang
Copy link
Contributor

Similar unrelated CI errors occur again and again 😭

@zeripath zeripath merged commit 0fa41b6 into go-gitea:main Nov 20, 2021
@zeripath zeripath deleted the fix-15612-update-locale-on-signin branch November 20, 2021 21:32
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 25, 2021
Backport go-gitea#17734

When logging in reset the user's locale to ensure that it matches their
preferred locale.

Fix go-gitea#15612

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
lunny pushed a commit that referenced this pull request Dec 25, 2021
Backport #17734

When logging in reset the user's locale to ensure that it matches their
preferred locale.

Fix #15612

Signed-off-by: Andrew Thornton <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 28, 2021
* BUGFIXES
  * Revert "Fix delete u2f keys bug (go-gitea#18042)" (go-gitea#18107)
  * Migrating wiki don't require token, so we should move it out of the require form (go-gitea#17645) (go-gitea#18104)
  * Prevent NPE if gitea uploader fails to open url (go-gitea#18080) (go-gitea#18101)
  * Reset locale on login (go-gitea#17734) (go-gitea#18100)
  * Correctly handle failed migrations (go-gitea#17575) (go-gitea#18099)
  * Instead of using routerCtx just escape the url before routing (go-gitea#18086) (go-gitea#18098)
  * Quote references to the user table in consistency checks (go-gitea#18072) (go-gitea#18073)
  * Add NotFound handler (go-gitea#18062) (go-gitea#18067)
  * Ensure that git repository is closed before transfer (go-gitea#18049) (go-gitea#18057)
  * Use common sessioner for API and web routes (go-gitea#18114)
* TRANSLATION
  * Fix code search result hint on zh-CN (go-gitea#18053)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Dec 28, 2021
lunny added a commit that referenced this pull request Dec 30, 2021
* BUGFIXES
  * Revert "Fix delete u2f keys bug (#18042)" (#18107)
  * Migrating wiki don't require token, so we should move it out of the require form (#17645) (#18104)
  * Prevent NPE if gitea uploader fails to open url (#18080) (#18101)
  * Reset locale on login (#17734) (#18100)
  * Correctly handle failed migrations (#17575) (#18099)
  * Instead of using routerCtx just escape the url before routing (#18086) (#18098)
  * Quote references to the user table in consistency checks (#18072) (#18073)
  * Add NotFound handler (#18062) (#18067)
  * Ensure that git repository is closed before transfer (#18049) (#18057)
  * Use common sessioner for API and web routes (#18114)
* TRANSLATION
  * Fix code search result hint on zh-CN (#18053)

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
When logging in reset the user's locale to ensure that it matches their
preferred locale.

Fix go-gitea#15612

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI language setting problems
5 participants