Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 4, 2021

Fix #17543

I haven't add LastLogin here because it's related some user privacy and I will left it other PRs.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.15 labels Nov 4, 2021
@lunny lunny added the backport/done All backports for this PR have been created label Nov 4, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 4, 2021
@delvh delvh added this to the 1.16.0 milestone Nov 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #17546 (cc5b4f4) into main (cb9c818) will decrease coverage by 0.00%.
The diff coverage is 26.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17546      +/-   ##
==========================================
- Coverage   45.49%   45.49%   -0.01%     
==========================================
  Files         793      793              
  Lines       88766    88809      +43     
==========================================
+ Hits        40385    40404      +19     
- Misses      41868    41887      +19     
- Partials     6513     6518       +5     
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/login/session.go 3.03% <ø> (ø)
modules/templates/helper.go 51.02% <ø> (ø)
routers/web/user/auth.go 12.18% <0.00%> (ø)
services/auth/source/oauth2/store.go 0.00% <0.00%> (ø)
routers/web/repo/issue.go 38.68% <56.25%> (+0.09%) ⬆️
modules/convert/git_commit.go 87.90% <100.00%> (+0.19%) ⬆️
services/auth/source/oauth2/init.go 38.46% <100.00%> (+2.74%) ⬆️
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9625e...cc5b4f4. Read the comment docs.

@zeripath zeripath merged commit a161c2c into go-gitea:main Nov 5, 2021
@lunny lunny deleted the lunny/fix_api_commit_created branch November 5, 2021 06:14
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] commits api returns '0001-01-01T00:00:00Z' for created timestamp
7 participants