Skip to content

Conversation

@saitho
Copy link
Contributor

@saitho saitho commented Oct 16, 2021

When hovering over the pull request number, a popup opens with more details on the pull request.
In branch list, the contents are aligned to the right since the original link also is.

https://try.gitea.io/saitho/test/branches
Screenshot from 2021-10-16 16-47-43

Setting a text-align on popup solves that.

@wxiaoguang
Copy link
Contributor

No, you shouldn't overwrite the global style. Please check what's wrong with that element.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2021
@silverwind
Copy link
Member

silverwind commented Oct 16, 2021

Fomantic UI is using text-align: right to align non-text content and that rule unfortunately cascades into the popup content. A arguably better solution would be to change the column layout of the branch table to use flexbox with justify-content: space-between, probably also needs to be refactored to not use table because table does not work well with flexbox.

Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to take this as a temporary fix with that comment until we can refactor branch table to flexbox.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2021
@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 16, 2021
@6543 6543 added this to the 1.16.0 milestone Oct 16, 2021
@saitho
Copy link
Contributor Author

saitho commented Oct 16, 2021

I applied the suggestions.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2021
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit b9a2f26 into go-gitea:main Oct 17, 2021
@zeripath
Copy link
Contributor

Please send backport to release/v1.15

@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 20, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants