Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 31, 2021

  • Make GetTags() api similar to GetBranches()
  • Use it for Tag/Release page

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 31, 2021
@6543 6543 force-pushed the git.GetTags-paginate branch from 95d17de to ee1d856 Compare September 9, 2021 17:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #16897 (a5bbe02) into main (4c7a70b) will increase coverage by 0.03%.
The diff coverage is 49.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16897      +/-   ##
==========================================
+ Coverage   45.17%   45.21%   +0.03%     
==========================================
  Files         762      766       +4     
  Lines       86174    86596     +422     
==========================================
+ Hits        38932    39155     +223     
- Misses      40948    41102     +154     
- Partials     6294     6339      +45     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/doctor.go 0.00% <ø> (ø)
models/attachment.go 57.89% <0.00%> (-0.68%) ⬇️
modules/migrations/gitea_downloader.go 0.88% <0.00%> (-0.01%) ⬇️
modules/migrations/migrate.go 27.79% <ø> (ø)
modules/setting/repository.go 58.49% <ø> (ø)
modules/storage/minio.go 58.18% <0.00%> (ø)
modules/templates/helper.go 51.36% <0.00%> (ø)
routers/api/v1/repo/migrate.go 44.17% <0.00%> (ø)
routers/api/v1/repo/mirror.go 0.00% <0.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca0e79...a5bbe02. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 9, 2021
@6543 6543 marked this pull request as ready for review September 9, 2021 18:48
@6543 6543 added this to the 1.16.0 milestone Sep 9, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2021
@6543 6543 merged commit 77f604a into go-gitea:main Sep 10, 2021
@6543 6543 deleted the git.GetTags-paginate branch September 10, 2021 17:30
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants