Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Aug 16, 2021

There was a regression in #16544 whereby the default token url
for github was changed to the gitea one.

@techknowlogick techknowlogick added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 16, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Aug 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #16709 (5fb9197) into main (ea07726) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16709      +/-   ##
==========================================
+ Coverage   45.38%   45.41%   +0.03%     
==========================================
  Files         758      758              
  Lines       85306    85306              
==========================================
+ Hits        38713    38741      +28     
+ Misses      40313    40286      -27     
+ Partials     6280     6279       -1     
Impacted Files Coverage Δ
services/auth/source/oauth2/providers_custom.go 63.23% <100.00%> (ø)
modules/queue/unique_queue_disk_channel.go 47.26% <0.00%> (-1.37%) ⬇️
services/pull/pull.go 41.78% <0.00%> (ø)
modules/git/blame.go 67.14% <0.00%> (+1.42%) ⬆️
modules/log/event.go 62.50% <0.00%> (+1.85%) ⬆️
modules/queue/workerpool.go 55.72% <0.00%> (+2.67%) ⬆️
modules/cron/tasks_basic.go 88.34% <0.00%> (+2.91%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️
services/mirror/mirror.go 17.30% <0.00%> (+7.69%) ⬆️
models/repo_mirror.go 69.56% <0.00%> (+10.86%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea07726...5fb9197. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2021
@zeripath zeripath merged commit 37d0d94 into go-gitea:main Aug 17, 2021
@zeripath zeripath added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Aug 17, 2021
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch August 17, 2021 12:30
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants