Skip to content

Upgrade github.com/google/go-github v32.1.0 -> v37.0.0 #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 9, 2021

as title

@6543 6543 added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 9, 2021
@6543 6543 added this to the 1.16.0 milestone Aug 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #16661 (4d212ea) into main (d9ef43a) will decrease coverage by 0.03%.
The diff coverage is 85.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16661      +/-   ##
==========================================
- Coverage   45.38%   45.34%   -0.04%     
==========================================
  Files         757      757              
  Lines       85194    85138      -56     
==========================================
- Hits        38664    38607      -57     
- Misses      40273    40275       +2     
+ Partials     6257     6256       -1     
Impacted Files Coverage Δ
modules/migrations/error.go 0.00% <ø> (ø)
modules/migrations/github.go 68.26% <85.07%> (-1.52%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/unit.go 41.09% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/log/event.go 59.72% <0.00%> (-0.93%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
modules/queue/workerpool.go 55.72% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ef43a...4d212ea. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2021
@techknowlogick techknowlogick changed the title Upgrade github.com/google/go-github vv32.1.0 -> v37.0.0 Upgrade github.com/google/go-github v32.1.0 -> v37.0.0 Aug 9, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 9, 2021
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 9, 2021
@6543
Copy link
Member Author

6543 commented Aug 9, 2021

@techknowlogick did add refactor - are you ok with it too?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 10, 2021
@6543 6543 merged commit 89245ee into go-gitea:main Aug 10, 2021
@6543 6543 deleted the vendor_upgrade-github-client branch August 10, 2021 09:49
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants