Skip to content

Conversation

Jonher937
Copy link
Contributor

This improves the autofill suggestion on mobile devices and some password managers.
I got the ideas of those changes from this article from Twilio

It seems to improve autofilling in both mobile devices and desktop password managers as tested in Issue #15403

This improves the autofill suggestion on mobile devices and some password managers
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 17, 2021
@zeripath zeripath added this to the 1.16.0 milestone Jul 17, 2021
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jul 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16473 (3056d91) into main (ec35783) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16473      +/-   ##
==========================================
- Coverage   45.43%   45.42%   -0.02%     
==========================================
  Files         717      717              
  Lines       84184    84184              
==========================================
- Hits        38252    38243       -9     
- Misses      39780    39790      +10     
+ Partials     6152     6151       -1     
Impacted Files Coverage Δ
services/mailer/mail_comment.go 77.77% <0.00%> (-7.41%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/notification/mail/mail.go 36.27% <0.00%> (-1.97%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
services/pull/pull.go 41.93% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec35783...3056d91. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 18, 2021
@6543 6543 merged commit fd3f149 into go-gitea:main Jul 18, 2021
@Jonher937 Jonher937 deleted the 2fa-autofill branch July 18, 2021 00:23
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
This improves the autofill suggestion on mobile devices and some password managers
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants