Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 17, 2021

to prevent things new races ...

since we can only partially enable race detection we have to add a new task who do not generate a coverage file

once #1441 pass, we can remove this step

@6543 6543 added this to the 1.16.0 milestone Jul 17, 2021
@6543
Copy link
Member Author

6543 commented Jul 17, 2021

PS: should fail until #16468 got merged :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 17, 2021
@6543 6543 requested a review from zeripath July 17, 2021 16:48
@6543
Copy link
Member Author

6543 commented Jul 17, 2021

If this pull got merged I'll add a revert to #1441

@6543

This comment has been minimized.

@codecov-commenter
Copy link

Codecov Report

Merging #16470 (8e39b33) into main (0393a57) will increase coverage by 1.17%.
The diff coverage is 47.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16470      +/-   ##
==========================================
+ Coverage   44.24%   45.42%   +1.17%     
==========================================
  Files         695      717      +22     
  Lines       82341    84184    +1843     
==========================================
+ Hits        36429    38237    +1808     
+ Misses      40014    39798     -216     
- Partials     5898     6149     +251     
Impacted Files Coverage Δ
cmd/convert.go 0.00% <0.00%> (ø)
cmd/dump.go 0.91% <0.00%> (ø)
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/restore_repo.go 0.00% <0.00%> (ø)
... and 316 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83abfc...8e39b33. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 17, 2021
@6543 6543 merged commit 4b512ab into go-gitea:main Jul 17, 2021
@6543 6543 deleted the add-unit-test-with-race branch July 17, 2021 20:46
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants