Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Jun 27, 2021

There is a bug in modules/convert.ToCommit where the committer is used in place of the author.

This PR fixes this.

@6543 6543 added type/bug modifies/api This PR adds API routes or modifies them backport/v1.14 labels Jun 27, 2021
@6543 6543 added this to the 1.15.0 milestone Jun 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16276 (f017071) into main (9a0cd3a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16276      +/-   ##
==========================================
+ Coverage   45.40%   45.42%   +0.01%     
==========================================
  Files         709      709              
  Lines       83484    83484              
==========================================
+ Hits        37910    37919       +9     
+ Misses      39495    39481      -14     
- Partials     6079     6084       +5     
Impacted Files Coverage Δ
modules/convert/git_commit.go 87.70% <100.00%> (ø)
modules/indexer/stats/db.go 42.85% <0.00%> (-7.15%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
modules/notification/mail/mail.go 38.23% <0.00%> (+1.96%) ⬆️
modules/queue/workerpool.go 56.48% <0.00%> (+2.67%) ⬆️
models/unit.go 43.83% <0.00%> (+2.73%) ⬆️
services/mailer/mail_comment.go 85.18% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0cd3a...f017071. Read the comment docs.

@zeripath zeripath merged commit 59c5855 into go-gitea:main Jun 27, 2021
@zeripath zeripath deleted the fix-convert-commit-for-api branch June 27, 2021 22:15
@zeripath zeripath changed the title [API] Convert Commit for api respect author Fix API to use author for commits instead of committer Jun 27, 2021
@zeripath
Copy link
Contributor

Please send backport.

6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 27, 2021
@6543 6543 added the backport/done All backports for this PR have been created label Jun 27, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants