Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jun 4, 2021

When restore, we should not clone git data still from orginal URL but from local disk.

@lunny lunny added the type/bug label Jun 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16066 (195ad3d) into main (36dce0e) will decrease coverage by 0.03%.
The diff coverage is 26.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16066      +/-   ##
==========================================
- Coverage   44.10%   44.06%   -0.04%     
==========================================
  Files         682      682              
  Lines       82375    82460      +85     
==========================================
+ Hits        36328    36338      +10     
- Misses      40140    40205      +65     
- Partials     5907     5917      +10     
Impacted Files Coverage Δ
models/repo.go 53.67% <0.00%> (-0.58%) ⬇️
modules/auth/sso/reverseproxy.go 8.51% <0.00%> (ø)
modules/graceful/server_http.go 0.00% <0.00%> (ø)
modules/migrations/gitea_uploader.go 7.42% <0.00%> (-0.03%) ⬇️
modules/migrations/restore.go 0.00% <0.00%> (ø)
routers/events/events.go 0.00% <0.00%> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/org/setting.go 0.00% <0.00%> (ø)
routers/private/manager.go 0.00% <0.00%> (ø)
routers/private/restore_repo.go 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38f62a...195ad3d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 4, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2021
@lafriks lafriks merged commit 7979c36 into go-gitea:main Jun 4, 2021
@lunny lunny deleted the lunny/fix_migration branch June 4, 2021 13:26
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants