Skip to content

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 1, 2021

This PR is an alternative to #15891.

In this we do some basic parent tracking and if we discover that a path has a sha change when there is a single mainline we can declare that path found.

Further if we reach a point whereby the number of files is less than 70 we will ask git to track these in rev-list as it appears that git is fast enough at that point.

@zeripath zeripath added performance/speed performance issues with slow downs performance/bigrepo Performance Issues affecting Big Repositories labels Jun 1, 2021
@zeripath zeripath mentioned this pull request Jun 1, 2021
6 tasks
@zeripath
Copy link
Contributor Author

zeripath commented Jun 3, 2021

Closing in favour of #16059 which is faster

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2021
@zeripath zeripath closed this Jun 3, 2021
@zeripath
Copy link
Contributor Author

zeripath commented Jun 3, 2021

Reopening as this appears better tolerated by codeberg.

@zeripath zeripath reopened this Jun 3, 2021
@6543 6543 added this to the 1.15.0 milestone Jun 6, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16042 (4c851b1) into main (ee5e1c4) will increase coverage by 0.10%.
The diff coverage is 60.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16042      +/-   ##
==========================================
+ Coverage   44.06%   44.17%   +0.10%     
==========================================
  Files         683      683              
  Lines       82358    82518     +160     
==========================================
+ Hits        36295    36455     +160     
+ Misses      40176    40138      -38     
- Partials     5887     5925      +38     
Impacted Files Coverage Δ
modules/git/pipeline/lfs_nogogit.go 0.00% <0.00%> (ø)
modules/indexer/code/bleve.go 68.22% <0.00%> (-0.59%) ⬇️
modules/indexer/code/elastic_search.go 1.64% <0.00%> (-0.02%) ⬇️
modules/git/repo_language_stats_nogogit.go 43.90% <33.33%> (-0.68%) ⬇️
modules/git/batch_reader.go 50.42% <50.61%> (-3.33%) ⬇️
modules/git/commit_info_nogogit.go 68.21% <72.17%> (+0.11%) ⬆️
modules/indexer/stats/db.go 42.85% <0.00%> (-7.15%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-5.00%) ⬇️
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 62.50% <0.00%> (-2.78%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ef6a6...4c851b1. Read the comment docs.

@zeripath zeripath removed this from the 1.15.0 milestone Jun 27, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@zeripath zeripath deleted the get-last-commit-parent-tracking branch December 29, 2022 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. performance/bigrepo Performance Issues affecting Big Repositories performance/speed performance issues with slow downs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants