Skip to content

Hide mirror passwords on repo settings page #16022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2021
Merged

Hide mirror passwords on repo settings page #16022

merged 2 commits into from
May 31, 2021

Conversation

zeripath
Copy link
Contributor

This PR simply hides mirror passwords from being displayed on the repo settings page.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Hide mirror passwords on repo settings page
674c1ac 
This PR simply hides mirror passwords from being displayed on the repo settings page.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 29, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 29, 2021
@zeripath zeripath requested a review from kdumontnu May 29, 2021 16:47
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021 •
edited
Loading

Codecov Report

Merging #16022 (74aeedc) into main (cb940c4) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16022   +/-   ##
=======================================
  Coverage   44.07%   44.07%           
=======================================
  Files         682      682           
  Lines       82420    82424    +4     
=======================================
+ Hits        36326    36328    +2     
- Misses      40175    40177    +2     
  Partials     5919     5919
Impacted Files Coverage Δ
routers/repo/setting.go 13.53% <0.00%> (-0.08%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 26.02% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
services/pull/pull.go 43.83% <0.00%> (+0.45%) ⬆️
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/queue/workerpool.go 54.96% <0.00%> (+1.90%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb940c4...74aeedc. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2021
@zeripath zeripath merged commit 7a484c0 into go-gitea:main May 31, 2021
@zeripath zeripath deleted the fix-kdumont branch May 31, 2021 10:46
kdumontnu added a commit to AllSpiceIO/gitea that referenced this pull request Jul 6, 2021
@kdumontnu
Hide mirror passwords on repo settings page (go-gitea#16022)
f8d7334
@kdumontnu kdumontnu mentioned this pull request Jul 6, 2021
Merged
@lunny lunny added backport/done All backports for this PR have been created backport/v1.14 labels Jul 7, 2021
6543 pushed a commit that referenced this pull request Jul 7, 2021
@kdumontnu
Hide mirror passwords on repo settings page (#16022) (#16355)
6e5fd5c
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @techknowlogick @AbdulrhmnGhanem
Hide mirror passwords on repo settings page (go-gitea#16022)
6b10b9f 
This PR simply hides mirror passwords from being displayed on the repo settings page.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@kdumontnu kdumontnu Awaiting requested review from kdumontnu

+1 more reviewer

@noerw noerw noerw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @codecov-commenter @lunny @noerw @GiteaBot @techknowlogick