Skip to content

Restore token authentication for git http when 2FA active #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2021
Merged

Restore token authentication for git http when 2FA active #15915

merged 3 commits into from
May 19, 2021

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented May 18, 2021

There was a small regression in #15303 whereby token auth
with 2FA active would be disallowed.

This PR fixes this.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Restore token authentication for git http when 2FA active
6904aa7 
There was a small regression in go-gitea#15303 whereby token auth
with 2FA active would be disallowed.

This PR fixes this.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 18, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 18, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #15915 (e0a4a04) into main (ba76bd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15915      +/-   ##
==========================================
- Coverage   44.02%   44.01%   -0.01%     
==========================================
  Files         681      681              
  Lines       82336    82340       +4     
==========================================
- Hits        36246    36243       -3     
- Misses      40188    40193       +5     
- Partials     5902     5904       +2
Impacted Files Coverage Δ
modules/git/command.go 87.96% <100.00%> (+0.46%) ⬆️
routers/repo/http.go 44.66% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/avatar/avatar.go 47.72% <0.00%> (-4.55%) ⬇️
modules/log/file.go 73.80% <0.00%> (-1.59%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 43.83% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825547b...e0a4a04. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2021
@techknowlogick techknowlogick merged commit 0e56e9c into go-gitea:main May 19, 2021
@zeripath zeripath deleted the fix-otp-token-auth branch May 19, 2021 06:35
@kimdre kimdre mentioned this pull request May 19, 2021
Closed
6 tasks
@zeripath zeripath linked an issue May 19, 2021 that may be closed by this pull request
Personal Access Tokens no longer work with https when 2fa is turned on. #15919
Closed
6 tasks
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @6543 @AbdulrhmnGhanem
Restore token authentication for git http when 2FA active (go-gitea#1…
98df501 
…5915)

There was a small regression in go-gitea#15303 whereby token auth
with 2FA active would be disallowed.

This PR fixes this.

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees

No one assigned

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

Personal Access Tokens no longer work with https when 2fa is turned on.

6 participants

@zeripath @codecov-commenter @silverwind @6543 @techknowlogick @GiteaBot