Skip to content

Fix and restyle menu on code line #15913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2021
Merged

Fix and restyle menu on code line #15913

merged 7 commits into from
May 19, 2021

Conversation

silverwind
Copy link
Member

Before:
Screen Shot 2021-05-17 at 23 19 12

After:
Screen Shot 2021-05-17 at 23 20 04
Screen Shot 2021-05-17 at 23 20 13

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label May 17, 2021
@silverwind
Copy link
Member Author

silverwind commented May 17, 2021 •
edited
Loading

Moved js/less to separate files, might be a bit overkill for such a tiny feature 😉.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2021
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 17, 2021
@silverwind silverwind added the pr/wip This PR is not ready for review label May 17, 2021
@silverwind silverwind removed the pr/wip This PR is not ready for review label May 18, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2021
@lunny
Copy link
Member

lunny commented May 19, 2021

Moved js/less to separate files, might be a bit overkill for such a tiny feature 😉.

I feel it's great. It's a continuous refactor.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 370cfde into go-gitea:main May 19, 2021
@silverwind silverwind deleted the codemenu branch May 19, 2021 08:34
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@silverwind @6543
@lunny @techknowlogick @AbdulrhmnGhanem
Fix and restyle menu on code line (go-gitea#15913)
05e68dc 
* Fix and restyle menu on code line

* fix multiline and more tweaks

* move to separate files

* remove has-context-menu class

Co-authored-by: 6543 <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @lunny @techknowlogick @6543 @GiteaBot