Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented May 16, 2021

As title

@lunny lunny added the type/enhancement An improvement of existing functionality label May 16, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15890 (70e7652) into main (3a04d6f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15890      +/-   ##
==========================================
- Coverage   44.03%   44.01%   -0.02%     
==========================================
  Files         681      681              
  Lines       82333    82336       +3     
==========================================
- Hits        36252    36237      -15     
- Misses      40180    40194      +14     
- Partials     5901     5905       +4     
Impacted Files Coverage Δ
models/admin.go 59.09% <0.00%> (-2.82%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/queue/unique_queue_disk_channel.go 48.63% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a04d6f...70e7652. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2021
@lunny lunny merged commit 0bf8d34 into go-gitea:main May 16, 2021
@lunny lunny deleted the lunny/empty_notice branch May 16, 2021 11:58
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants