Skip to content

Fix error message when saving generated LOCAL_ROOT_URL config #15880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2021

Conversation

tiqwab
Copy link
Contributor

@tiqwab tiqwab commented May 15, 2021

What is saved here is LOCAL_ROOT_URL not JWT secret.

@codecov-commenter
Copy link

Codecov Report

Merging #15880 (842c902) into main (b6b8b19) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15880      +/-   ##
==========================================
- Coverage   44.00%   43.98%   -0.03%     
==========================================
  Files         681      681              
  Lines       82270    82270              
==========================================
- Hits        36205    36185      -20     
- Misses      40158    40175      +17     
- Partials     5907     5910       +3     
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
modules/indexer/stats/db.go 42.85% <0.00%> (-7.15%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 26.02% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.73% <0.00%> (-1.50%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
models/error.go 39.37% <0.00%> (-0.48%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b8b19...842c902. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2021
@zeripath zeripath merged commit 9f19c2b into go-gitea:main May 15, 2021
@zeripath
Copy link
Contributor

Please send backport

tiqwab added a commit to tiqwab/gitea that referenced this pull request May 15, 2021
@zeripath zeripath added the backport/done All backports for this PR have been created label May 15, 2021
@tiqwab tiqwab deleted the fix-error-message-set-port branch May 16, 2021 01:09
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants