Skip to content

Add jest rootDir and test-frontend dependency #15860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2021
Merged

Add jest rootDir and test-frontend dependency #15860

merged 3 commits into from
May 14, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 13, 2021 •
edited
Loading

  • Define jest rootDir to limit where it looks for test files, speeding it up a bit
  • Add missing dependency on test-frontend target so it can be ran from a clean checkout

@silverwind
Add jest rootDir and test-frontend dependency
a3ba49e 
- Define jest rootDir to limit where it looks for test files
- Add missing dependency on test-frontend target so it can be ran from a
  clean checkout
@silverwind silverwind added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 13, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 13, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 13, 2021
@zeripath
Copy link
Contributor

Did this make it in to 1.14? If so as it will speed up build it may be worth backporting.

@silverwind
Copy link
Member Author

No, test-frontend is 1.15 only. The speedup is very minor, only like 2 seconds on CI, bit still noticeable.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2021
@zeripath
Copy link
Contributor

Make lgtm work

@zeripath zeripath merged commit 05fb1f6 into go-gitea:main May 14, 2021
@silverwind silverwind deleted the jesttweak branch May 14, 2021 06:57
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@silverwind @AbdulrhmnGhanem
Add jest rootDir and test-frontend dependency (go-gitea#15860)
01a8f47 
- Define jest rootDir to limit where it looks for test files
- Add missing dependency on test-frontend target so it can be ran from a
  clean checkout
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@noerw noerw noerw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @zeripath @noerw @GiteaBot @techknowlogick