Skip to content

Conversation

zeripath
Copy link
Contributor

Backport #15758

  • Fix bound address/port for caddy's certmagic library

  • Fix bug

Backport go-gitea#15758

* Fix bound address/port for caddy's certmagic library

* Fix bug

Co-authored-by: zeripath <[email protected]>
@zeripath zeripath added this to the 1.14.3 milestone May 12, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2021
@zeripath
Copy link
Contributor Author

Make lgtm work

@zeripath zeripath merged commit 62daf84 into go-gitea:release/v1.14 May 12, 2021
@zeripath zeripath deleted the backport-15758-v1.14 branch May 12, 2021 22:36
@bminer
Copy link
Contributor

bminer commented May 13, 2021

I don't think this PR solves the issue. Still debugging...

@zeripath
Copy link
Contributor Author

Some you win -- some you lose...

@bminer
Copy link
Contributor

bminer commented May 13, 2021

Yeah... so I have it sorted now. I will make a new PR referencing this one. Sorry for the confusion. Took me a bit to build gitea on ARMv7 with cgo.

bminer added a commit to bminer/gitea that referenced this pull request May 13, 2021
zeripath pushed a commit to zeripath/gitea that referenced this pull request May 14, 2021
zeripath added a commit that referenced this pull request May 15, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants