Skip to content

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented May 5, 2021

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton [email protected]

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.14 labels May 5, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 5, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2021
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2021
@zeripath
Copy link
Contributor Author

zeripath commented May 5, 2021

Make lgtm work

@zeripath zeripath merged commit e071b53 into go-gitea:main May 5, 2021
@zeripath zeripath deleted the fix-comment-and-close-issue branch May 5, 2021 22:46
zeripath added a commit to zeripath/gitea that referenced this pull request May 6, 2021
Backport go-gitea#15737

* Fix close button change on delete in simplemde area

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton <[email protected]>

* apply suggestion

Co-authored-by: 6543 <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label May 6, 2021
zeripath added a commit that referenced this pull request May 6, 2021
Backport #15737

* Fix close button change on delete in simplemde area

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton <[email protected]>

* apply suggestion

Co-authored-by: 6543 <[email protected]>

Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* Fix close button change on delete in simplemde area

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton <[email protected]>

* apply suggestion

Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants