Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 29, 2021

close #15668

@codecov-commenter
Copy link

Codecov Report

Merging #15657 (cdb6e80) into master (d7dbe4f) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15657      +/-   ##
==========================================
+ Coverage   43.91%   43.92%   +0.01%     
==========================================
  Files         678      678              
  Lines       81743    81746       +3     
==========================================
+ Hits        35895    35911      +16     
+ Misses      40001    39989      -12     
+ Partials     5847     5846       -1     
Impacted Files Coverage Δ
models/consistency.go 38.76% <66.66%> (+2.50%) ⬆️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.76% <0.00%> (+2.73%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7dbe4f...cdb6e80. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2021
@6543

This comment has been minimized.

@6543 6543 added this to the 1.15.0 milestone Apr 30, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2021
@6543
Copy link
Member

6543 commented Apr 30, 2021

🚀

@6543 6543 merged commit f5eb33c into go-gitea:master Apr 30, 2021
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 30, 2021
* Fix orphaned objects deletion bug

* extend test

Co-authored-by: 6543 <[email protected]>
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 30, 2021
* Fix orphaned objects deletion bug

* extend test

Co-authored-by: 6543 <[email protected]>
@6543 6543 added backport/done All backports for this PR have been created backport/v1.13 labels Apr 30, 2021
@6543
Copy link
Member

6543 commented Apr 30, 2021

Backports:

zeripath pushed a commit that referenced this pull request Apr 30, 2021
* Fix orphaned objects deletion bug

* extend test

Co-authored-by: 6543 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
zeripath added a commit that referenced this pull request Apr 30, 2021
* Fix orphaned objects deletion bug

* extend test

Co-authored-by: 6543 <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: zeripath <[email protected]>
@lunny lunny deleted the lunny/fix_orphan_objects branch May 1, 2021 07:52
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Doctor] db consistency fix function not working
6 participants