Return go-get info on subdirs. Fixes #15625 #15628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm... I think we need to be clearer about when we want the go-get handler to fire. Is it that any url: and all need to go to the go-get handler? If so then we're better off making this a handler within |
GiteaBot
added
the
lgtm/need 2
|
Afaik it needs to fire on all possible import paths. See also |
|
More or less, Theoretically only real sub-directories within the repo matter, but it would likely be easier to just implement a wildcard and be done with it. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 27, 2021
This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
May 9, 2021
This PR is an alternative to #15628 and makes the go get handler a handler. Fix #15625 Close #15628 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 14, 2021
Backport go-gitea#15642 This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
May 15, 2021
Backport #15642 This PR is an alternative to #15628 and makes the go get handler a handler. Fix #15625 Close #15628 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
This PR is an alternative to go-gitea#15628 and makes the go get handler a handler. Fix go-gitea#15625 Close go-gitea#15628 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return go-get info on subdirs, if we're not requesting "?go-get=1" return NotFound
Fixes #15625