Skip to content

go get for modules in subdirs broken since 1.14.x #15625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 6 tasks
42wim opened this issue Apr 26, 2021 · 0 comments · Fixed by #15642
Closed
2 of 6 tasks

go get for modules in subdirs broken since 1.14.x #15625

42wim opened this issue Apr 26, 2021 · 0 comments · Fixed by #15642
Labels
type/bug

Comments

@42wim
Copy link
Member

42wim commented Apr 26, 2021

  • Gitea version (or commit ref): 1.14.1
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

Running go get on modules where the go.mod is in a subdir instead of the root eg http://gitea/owner/repo/subdir?go-get=1 will now always return a 404 which makes go get fail.

On gitea 1.13 a 200 OK was returned
@42wim 42wim mentioned this issue Apr 26, 2021
Closed
42wim added a commit to 42wim/gitea that referenced this issue Apr 26, 2021
@42wim
Return go-get info on subdirs. Fixes go-gitea#15625
ae02058
zeripath added a commit to zeripath/gitea that referenced this issue Apr 27, 2021
@zeripath
Return go-get info on subdirs
9ace36a 
This PR is an alternative to go-gitea#15628 and makes the go get handler a
handler.

Fix go-gitea#15625

Close go-gitea#15628

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Apr 27, 2021
Merged
zeripath added a commit that referenced this issue May 9, 2021
@zeripath
Return go-get info on subdirs (#15642)
038e1db 


This PR is an alternative to #15628 and makes the go get handler a
handler.

Fix #15625

Close #15628

Signed-off-by: Andrew Thornton <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue May 14, 2021
@zeripath
Return go-get info on subdirs (go-gitea#15642)
af9afd4 
Backport go-gitea#15642

This PR is an alternative to go-gitea#15628 and makes the go get handler a
handler.

Fix go-gitea#15625

Close go-gitea#15628

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue May 14, 2021
Merged
zeripath added a commit that referenced this issue May 15, 2021
@zeripath @6543
Return go-get info on subdirs (#15642) (#15871)
a3e8450 
Backport #15642

This PR is an alternative to #15628 and makes the go get handler a
handler.

Fix #15625

Close #15628

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Return go-get info on subdirs (go-gitea#15642)
67e2684 


This PR is an alternative to go-gitea#15628 and makes the go get handler a
handler.

Fix go-gitea#15625

Close go-gitea#15628

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
2 participants
@42wim @jolheiser