Skip to content

Fix bug clone wiki #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Fix bug clone wiki #15499

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89fdf2c
Fix bug clone wiki
lunny Apr 15, 2021
daee0f9
Merge branch 'master' into lunny/fix_http_clone_wiki
6543 Apr 15, 2021
10ce1d6
Update routers/repo/http.go
6543 Apr 15, 2021
fa2f74b
Merge branch 'master' into lunny/fix_http_clone_wiki
zeripath Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions routers/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,11 @@ func httpBase(ctx *context.Context) (h *serviceHandler) {

isWiki := false
var unitType = models.UnitTypeCode
var wikiRepoName string
if strings.HasSuffix(reponame, ".wiki") {
isWiki = true
unitType = models.UnitTypeWiki
wikiRepoName = reponame
reponame = reponame[:len(reponame)-5]
}

Expand Down Expand Up @@ -314,6 +316,11 @@ func httpBase(ctx *context.Context) (h *serviceHandler) {
return
}

if isWiki { // you cannot send wiki operation before create the repository
ctx.HandleText(http.StatusNotFound, "Repository not found")
return
}

if owner.IsOrganization() && !setting.Repository.EnablePushCreateOrg {
ctx.HandleText(http.StatusForbidden, "Push to create is not enabled for organizations.")
return
Expand Down Expand Up @@ -363,6 +370,9 @@ func httpBase(ctx *context.Context) (h *serviceHandler) {
r.URL.Path = strings.ToLower(r.URL.Path) // blue: In case some repo name has upper case name

dir := models.RepoPath(username, reponame)
if isWiki {
dir = models.RepoPath(username, wikiRepoName)
}

return &serviceHandler{cfg, w, r, dir, cfg.Env}
}
Expand Down