Skip to content

Conversation

@zeripath
Copy link
Contributor

Copy the icon code from templates/repo/issue/view_issue.tmpl

Fix #15272

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added topic/ui Change the appearance of the Gitea UI backport/v1.14 labels Apr 10, 2021
@zeripath zeripath added this to the 1.15.0 milestone Apr 10, 2021
@silverwind
Copy link
Member

Subtemplate possible? 😉

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2021
@codecov-io
Copy link

Codecov Report

Merging #15387 (38ec33e) into master (84f5a0b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15387      +/-   ##
==========================================
- Coverage   43.93%   43.91%   -0.03%     
==========================================
  Files         677      677              
  Lines       81332    81332              
==========================================
- Hits        35732    35713      -19     
- Misses      39804    39818      +14     
- Partials     5796     5801       +5     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
modules/indexer/code/elastic_search.go 0.00% <0.00%> (-1.66%) ⬇️
modules/log/file.go 73.80% <0.00%> (-1.59%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.73% <0.00%> (-1.50%) ⬇️
modules/base/tool.go 93.30% <0.00%> (-0.96%) ⬇️
models/issue_comment.go 52.16% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 43.30% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f5a0b...38ec33e. Read the comment docs.

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 8171478 into go-gitea:master Apr 11, 2021
@zeripath zeripath deleted the fix-15272-standardise-pr-icon branch April 11, 2021 20:13
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 11, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 11, 2021
6543 pushed a commit that referenced this pull request Apr 12, 2021
6543 pushed a commit that referenced this pull request Apr 12, 2021
@6543 6543 added the backport/done All backports for this PR have been created label Apr 12, 2021
aswild added a commit to aswild/gitea that referenced this pull request May 3, 2021
v1.14.1

* BUGFIXES
  * Fix bug clone wiki (go-gitea#15499) (go-gitea#15502)
  * Github Migration ignore rate limit, if not enabled (go-gitea#15490) (go-gitea#15495)
  * Use subdir for URL (go-gitea#15446) (go-gitea#15493)
  * Query the DB for the hash before inserting in to email_hash (go-gitea#15457) (go-gitea#15491)
  * Ensure review dismissal only dismisses the correct review (go-gitea#15477) (go-gitea#15489)
  * Use index of the supported tags to choose user lang (go-gitea#15452) (go-gitea#15488)
  * Fix wrong file link in code search page (go-gitea#15466) (go-gitea#15486)
  * Quick template fix for built-in SSH server in admin config (go-gitea#15464) (go-gitea#15481)
  * Prevent superfluous response.WriteHeader (go-gitea#15456) (go-gitea#15476)
  * Fix ambiguous argument error on tags (go-gitea#15432) (go-gitea#15474)
  * Add created_unix instead of expiry to migration (go-gitea#15458) (go-gitea#15463)
  * Fix repository search (go-gitea#15428) (go-gitea#15442)
  * Prevent NPE on avatar direct rendering if federated avatars disabled (go-gitea#15434) (go-gitea#15439)
  * Fix wiki clone urls (go-gitea#15430) (go-gitea#15431)
  * Fix dingtalk icon url at webhook (go-gitea#15417) (go-gitea#15426)
  * Standardise icon on projects PR page (go-gitea#15387) (go-gitea#15408)
* ENHANCEMENTS
  * Add option to skip LFS/attachment files for `dump` (go-gitea#15407) (go-gitea#15492)
  * Clone panel fixes (go-gitea#15436)
  * Use semantic dropdown for code search query type (go-gitea#15276) (go-gitea#15364)
* BUILD
  * Build go-git variants for windows (go-gitea#15482) (go-gitea#15487)
  * Lock down build-images dependencies (Partial go-gitea#15479) (go-gitea#15480)
* MISC
  * Performance improvement for list pull requests (go-gitea#15447) (go-gitea#15500)
  * Fix potential copy lfs records failure when fork a repository (go-gitea#15441) (go-gitea#15485)
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/projects topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Merged PRs appear as closed in Projects view

9 participants