Skip to content

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 6, 2021

Whilst doing other work I have noticed that there is an issue with Wrap when passing an
http.Handler - the next should be the next handler in line not empty.

Signed-off-by: Andrew Thornton [email protected]

Whilst doing other work I have noticed that there is an issue with Wrap when passing an
http.Handler - the next should be the next handler in line not empty.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.15.0 milestone Apr 6, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2021
@6543
Copy link
Member

6543 commented Apr 6, 2021

🚀

@6543 6543 merged commit b101fa8 into go-gitea:master Apr 6, 2021
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Apr 6, 2021
Whilst doing other work I have noticed that there is an issue with Wrap when passing an
http.Handler - the next should be the next handler in line not empty.

Signed-off-by: Andrew Thornton <[email protected]>
@6543 6543 mentioned this pull request Apr 6, 2021
@zeripath zeripath deleted the fix-wrap branch April 6, 2021 16:19
@6543 6543 added the backport/done All backports for this PR have been created label Apr 6, 2021
6543 added a commit that referenced this pull request Apr 6, 2021
Whilst doing other work I have noticed that there is an issue with Wrap when passing an
http.Handler - the next should be the next handler in line not empty.

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants