use level config in log section when sub log section not set level #15176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in previouse if a log subsetcion not set level
it will use ``info`` as default value.
this pr will make default value (``[log] -> LEVEL``) useable.
example config:
```INI
[log]
MODE = console
LEVEL = Trace
[log.console]
LEVEL =
STDERR = false
```
previous result:
```JSON
// console:
{
"level": "info",
...................
}
```
after change:
```JSON
// console:
{
"level": "track",
...................
}
```
Signed-off-by: a1012112796 <[email protected]>
Member
Author
|
not confirm whether it's a bug fix or enhancement .... |
GiteaBot
added
the
lgtm/need 2
a1012112796
changed the title
Codecov Report
@@ Coverage Diff @@
## master #15176 +/- ##
=========================================
Coverage ? 43.54%
=========================================
Files ? 668
Lines ? 80600
Branches ? 0
=========================================
Hits ? 35098
Misses ? 39794
Partials ? 5708
Continue to review full report at Codecov.
|
zeripath
approved these changes
Mar 27, 2021
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
it's probably a breaking change but definitely looks like an oversight on my behalf
GiteaBot
added
lgtm/need 1
richmahn
approved these changes
Mar 27, 2021
GiteaBot
added
lgtm/done
Contributor
|
LGTM as well. |
lafriks
approved these changes
Mar 28, 2021
6543
added
pr/breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in previouse if a log subsetcion not set level
it will use
infoas default value.this pr will make default value (
[log] -> LEVEL) useable.example config:
Prior to this change sub loggers would use the default logger level of
INFOif not set - they will now inherit from the main logger.Administrators should check their log configuration.
Screenshots
previous result:
after:
fix #15170