Skip to content

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Mar 26, 2021

There is a missing and a misplaced </div> closing tag in the navbar.tmpl.

For the organisation dashboard, this resulted in the footer being displayed incorrectly (immediately after the content instead of at the bottom of the page):

image

This should be backported to 1.14 as well.

Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, thats my fault. thanks

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 26, 2021
@noerw noerw added this to the 1.15.0 milestone Mar 26, 2021
@noerw noerw added backport/v1.14 type/bug topic/ui Change the appearance of the Gitea UI labels Mar 26, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2021
@6543 6543 merged commit 6b836ac into go-gitea:master Mar 26, 2021
@6543 6543 added the backport/done All backports for this PR have been created label Mar 26, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants