Skip to content

Expose resolver via API #15167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2021
Merged

Expose resolver via API #15167

merged 3 commits into from
Mar 27, 2021

Conversation

sotho
Copy link
Contributor

@sotho sotho commented Mar 26, 2021

  • Add a new field to the API to expose the "resolver" of a comment/
    conversation. This is not available in the GitHub API v3.
  • Extend struct to contain "Resolver". Might be empty (nil).
  • Rename "Reviewer" to "Poster" in PullReviewComment to make it
    clear this is the person posting a comment. The API is unchanged
    ('user').
  • Only the first comment of a conversation might have a resolver,
    the others seem to be always nil.

@noerw noerw added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Mar 26, 2021
@techknowlogick techknowlogick added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Mar 26, 2021
@sotho sotho force-pushed the expose-resolver branch from 4adfe31 to 97183d5 Compare March 26, 2021 16:31
@sotho
Expose resolver via API
5583c03 
* Add a new field to the API to expose the "resolver" of a comment/
  conversation. This is not available in the GitHub API v3.
* Extend struct to contain "Resolver". Might be empty (nil).
* Rename "Reviewer" to "Poster" in PullReviewComment to make it
  clear this is the person posting a comment. The API is unchanged
  ('user').
* Only the first comment of a conversation might have a resolver,
  the others seem to be always nil.
@sotho sotho force-pushed the expose-resolver branch from 97183d5 to 5583c03 Compare March 26, 2021 21:07
@6543 6543 added this to the 1.15.0 milestone Mar 26, 2021
@6543 6543 removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Mar 26, 2021
@richmahn
Copy link
Contributor

@sotho build is failing. Not sure why just on pgsql though.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 27, 2021
@codecov-io
Copy link

codecov-io commented Mar 27, 2021 •
edited
Loading

Codecov Report

Merging #15167 (7c4c982) into master (290cf75) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15167      +/-   ##
==========================================
+ Coverage   43.38%   43.54%   +0.15%     
==========================================
  Files         668      668              
  Lines       80620    80621       +1     
==========================================
+ Hits        34980    35104     +124     
+ Misses      39946    39808     -138     
- Partials     5694     5709      +15
Impacted Files Coverage Δ
modules/convert/pull_review.go 84.00% <100.00%> (+0.21%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/util/remove.go 65.38% <0.00%> (-15.39%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
routers/repo/view.go 41.03% <0.00%> (-0.62%) ⬇️
models/gpg_key.go 53.51% <0.00%> (-0.57%) ⬇️
services/pull/pull.go 42.82% <0.00%> (-0.49%) ⬇️
models/error.go 38.09% <0.00%> (ø)
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290cf75...7c4c982. Read the comment docs.

@6543
Copy link
Member

6543 commented Mar 27, 2021

@sotho please ajust / resolve conflicts - as per #15144

zeripath
zeripath reviewed Mar 27, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2021
@zeripath
placate lint
7c4c982 
Signed-off-by: Andrew Thornton <[email protected]>
@6543 6543 merged commit e760992 into go-gitea:master Mar 27, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sotho @richmahn @codecov-io @6543 @zeripath @techknowlogick @noerw @GiteaBot