Skip to content

Conversation

@noerw
Copy link
Member

@noerw noerw commented Feb 28, 2021

Let users know that warnings on "untrusted signature" don't mean a failed GPG validation.

This additional hint is targeted at novice users; people who know pgp well enough will understand gpg's output anyway.
If we'd instead aim to remove the warning (by adding a command to set the trustlevel for gitea's key) most people would blindly trust the docs, defeating the purpose of that gpg warning.

ref #14817

@noerw noerw added the type/docs This PR mainly updates/creates documentation label Feb 28, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #14832 (c0b7658) into main (dfa18a8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14832      +/-   ##
==========================================
+ Coverage   45.42%   45.43%   +0.01%     
==========================================
  Files         709      709              
  Lines       83611    83611              
==========================================
+ Hits        37981    37992      +11     
+ Misses      39538    39533       -5     
+ Partials     6092     6086       -6     
Impacted Files Coverage Δ
services/mailer/mail_comment.go 77.77% <0.00%> (-7.41%) ⬇️
modules/charset/charset.go 73.73% <0.00%> (-2.03%) ⬇️
modules/notification/mail/mail.go 36.27% <0.00%> (-1.97%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/queue/workerpool.go 54.58% <0.00%> (-0.39%) ⬇️
modules/queue/unique_queue_disk_channel.go 48.63% <0.00%> (+1.36%) ⬆️
services/gitdiff/gitdiff.go 73.90% <0.00%> (+1.41%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.75%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa18a8...c0b7658. Read the comment docs.

@6543 6543 merged commit fc1d962 into go-gitea:main Jul 1, 2021
@6543 6543 deleted the docs-gpg-trust branch July 1, 2021 14:14
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants