Skip to content

Fix go get #14758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2021
Merged

Fix go get #14758

merged 3 commits into from
Feb 21, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 20, 2021

Fix broken go get, Fix #14756

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 20, 2021
@lunny lunny added this to the 1.14.0 milestone Feb 20, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2021
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking as per @techknowlogick

@lunny
Copy link
Member Author

lunny commented Feb 21, 2021

@techknowlogick @zeripath Done.

@codecov-io
Copy link

Codecov Report

Merging #14758 (0ccdc98) into master (487f2ee) will decrease coverage by 0.00%.
The diff coverage is 39.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14758      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%     
==========================================
  Files         767      771       +4     
  Lines       81624    82079     +455     
==========================================
+ Hits        34458    34644     +186     
- Misses      41531    41786     +255     
- Partials     5635     5649      +14     
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 65.22% <0.00%> (+6.72%) ⬆️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 77.77% <0.00%> (-1.99%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56c19d...0ccdc98. Read the comment docs.

@lunny lunny merged commit bd93613 into go-gitea:master Feb 21, 2021
@lunny lunny deleted the lunny/fix_goget branch February 21, 2021 16:51
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go get broken because parameters cannot be retrieved from chi middleware
6 participants