Skip to content

Fix and simplify settings UI #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Morlinest
Copy link
Member

Fix #1418, simplify pages and fix collaboration page if there is no collaborator. Preview:

@sapk pls check

@lunny lunny added this to the 1.2.0 milestone Apr 5, 2017
@lunny lunny added the type/bug label Apr 5, 2017
@lunny
Copy link
Member

lunny commented Apr 6, 2017

Thanks! But on my local, I used chrome on Mac. collaboration still has a slight problem and could you also fixes branches UI?
untitled
untitled2

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2017
@Morlinest
Copy link
Member Author

Morlinest commented Apr 6, 2017

@lunny I've already send PR to fix branches UI, check #1435 pls

@lunny
Copy link
Member

lunny commented Apr 6, 2017

@Morlinest great for that. and the collaboration issue?

@Morlinest
Copy link
Member Author

@lunny Can not reproduce. Tested on Chrome, Firefox, IE 11 and Edge on Windows. I do not have Mac. Everywhere it looks good (as on my screenshot).

@sapk
Copy link
Member

sapk commented Apr 6, 2017

I will test it in few hours. Look good at first glance. Since you remove the .item:not(:first-child) for top border. have you check templates/user/settings/account_link.tmpl , templates/user/settings/applications.tmpl, templates/user/settings/email.tmpl , templates/user/settings/openid.tmpl ? They should simply need .divide maybe.

@sapk
Copy link
Member

sapk commented Apr 6, 2017

@sapk sapk mentioned this pull request Apr 6, 2017
@lunny
Copy link
Member

lunny commented Apr 19, 2017

Since #1456 is merged, should we close this one? @Morlinest @sapk

@Morlinest
Copy link
Member Author

Morlinest commented Apr 19, 2017

Yes, ill extract just one fix and create new PR

@Morlinest Morlinest closed this Apr 19, 2017
@lunny lunny removed this from the 1.2.0 milestone Apr 19, 2017
@Morlinest Morlinest deleted the fix-broken-UI branch April 24, 2017 09:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is broken on multiple pages
4 participants