-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
UI is broken on multiple pages #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@andreynering and others. |
For the hook and branch page the .settings .list .item:not(:first-child) (introduce in my PR #1389.) just need to not be applied on hook to fix UI. I will look into it furthermore. |
So .settings .list:not(.hook ) .item:not(:first-child) should be enough |
But a long term solution that I will have to look into is to improve #1389 and continue to remove specific css like .settings .hook.list |
Simply removing .table class from the parent of list : class="ui attached table segment" with removing specific .hook css code is enough to fix ui and remove also specific selector we could also remove hook class that is use also in branch html just to apply the same "hack". |
For org ->settings -> webhooks it is possible that my PR also impact since I remove some .grid code from css. I will have a look at it and maybe migrate to new UI format ? |
What about removing "&:not(:first-child)" and just use "ui divided list" instead? |
It is missing a space and border are not connected to border like there were before. Why not keeping item list and not changing the first desc to p since &:not(:first-child) is there to keep not display border-top on first item ? |
.settings .list .item:not(:first-child) { |
+1 : .divided could be a solution to go further at cleaning custom css but we will need to keep fix to extend borders to borders or find a other solution in semantic and use relaxed to add spacing in between horizontals borders. |
For dropdown .list .item need to be more specific to .list>.item |
I haven't time to test but for having .divided border we could simply set and remove all extras custom ? .settings .list.divided>.item { And globally you should keep the desc as .item so that it have a border at his bottom. (i think) Advice from long term maintainers could be good. |
Uh oh!
There was an error while loading. Please reload this page.
[x]
):Description
Broken UI graphic, at least on pages:
I think its caused by mergin PR #1389.
Another broken UI is on org ->settings -> webhooks (I think this was broken before).
Screenshots
repo -> settings -> branches:

repo -> settings -> githooks:

org ->settings -> webhooks:

The text was updated successfully, but these errors were encountered: