Skip to content

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jan 15, 2021

Currently uses ethantkoenig/rupture fork with fixes for v2 until ethantkoenig/rupture#9 is merged

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jan 15, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 15, 2021
@lunny
Copy link
Member

lunny commented Jan 15, 2021

ci failed related.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2021
@lafriks

This comment has been minimized.

@lafriks
Copy link
Member Author

lafriks commented Jan 15, 2021

I updated bleve search code to keep previous order and opened new issue #14348

@6543
Copy link
Member

6543 commented Jan 16, 2021

more or lest blocked by ethantkoenig/rupture#9

@lunny
Copy link
Member

lunny commented Jan 16, 2021

Please update branch

@lafriks
Copy link
Member Author

lafriks commented Jan 16, 2021

conflicts resolved

@lafriks
Copy link
Member Author

lafriks commented Jan 17, 2021

@6543 done

@codecov-io
Copy link

Codecov Report

Merging #14346 (57644f0) into master (dc66e47) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14346      +/-   ##
==========================================
- Coverage   41.87%   41.85%   -0.03%     
==========================================
  Files         744      744              
  Lines       79681    79681              
==========================================
- Hits        33368    33348      -20     
- Misses      40816    40833      +17     
- Partials     5497     5500       +3     
Impacted Files Coverage Δ
modules/indexer/code/bleve.go 71.16% <ø> (ø)
modules/indexer/issues/bleve.go 69.50% <ø> (ø)
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.52% <0.00%> (-2.95%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
models/repo_list.go 77.87% <0.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6155ff...57644f0. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2021
@techknowlogick
Copy link
Member

@lafriks please update branch

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit f5abe2f into go-gitea:master Jan 18, 2021
@lafriks lafriks deleted the feat/update_bleve branch January 18, 2021 01:42
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants