Revert #13857 #14285
Closed
Revert #13857 #14285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1c9e8f
Codecov Report
@@ Coverage Diff @@
## master #14285 +/- ##
==========================================
+ Coverage 41.83% 41.93% +0.09%
==========================================
Files 743 736 -7
Lines 79395 79019 -376
==========================================
- Hits 33212 33133 -79
+ Misses 40718 40427 -291
+ Partials 5465 5459 -6
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
@lunny do how far is chi migration going? If it's quit finished, I think we dont need to revert, but if it will take still some time we could consider this here as hotfix |
|
This is critical and breaking, it NEEDS to be reverted if fix is not being proposed |
GiteaBot
added
lgtm/need 1
6543
added
the
skip-changelog
|
As you wish |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #13857 and subsequently #14263 with the exception of keeping modified Drone config that performs tests against Windows builds.
The current implementation of #13857 is broken as it creates two separate sessions that fight, overwriting each other and making logging in impossible on any session provider that is not
memory.Fixes #14271