Kd/fix team avatar aspect ratio #14200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdumontnu
force-pushed
the
kd/fix-team_avatar_aspect_ratio
branch
from
2a2013a to
ecd8f42
Compare
Codecov Report
@@ Coverage Diff @@
## master #14200 +/- ##
=======================================
Coverage 41.96% 41.97%
=======================================
Files 735 735
Lines 78928 78928
=======================================
+ Hits 33126 33130 +4
+ Misses 40347 40344 -3
+ Partials 5455 5454 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jan 3, 2021
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jan 3, 2021
GiteaBot
added
lgtm/done
lafriks
added
the
skip-changelog
|
@kdumontnu pleace "Update Branch" |
|
please update the branch. In general it's better if you allow maintainers to push to the branch. |
|
@zeripath this fork belongs to an org, so the standard maintainer checkbox isn’t an option :( |
|
@zeripath @6543 @techknowlogick all set |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken aspect ratio for avatars in org members list admin page.
Before:
After:
aspect ratio is preserved for avatar (with fixed width)
min-width is set to prevent single-character text lines