Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Dec 15, 2020

Fixes #12292 - stores snap repo data in common directory so it isn't set to store in previous snap version path.

Previously it is set to store repo data in $HOME if not set, instead this sets it to store in AppDataPath if not set. Checked for breaking on arch & alpine and doesn't break them, however as this changes a default setting I've marked it as breaking.

@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Dec 15, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 15, 2020
@techknowlogick techknowlogick added the topic/distribution This PR changes something about the packaging of Gitea label Dec 15, 2020
@codecov-io
Copy link

Codecov Report

Merging #13991 (76c1d29) into master (c3fc190) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13991      +/-   ##
==========================================
- Coverage   42.23%   42.21%   -0.02%     
==========================================
  Files         710      710              
  Lines       77233    77230       -3     
==========================================
- Hits        32617    32606      -11     
- Misses      39245    39250       +5     
- Partials     5371     5374       +3     
Impacted Files Coverage Δ
modules/setting/repository.go 57.69% <100.00%> (+1.32%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.19%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
services/mirror/mirror.go 15.78% <0.00%> (-1.11%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3fc190...76c1d29. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2020
@6543
Copy link
Member

6543 commented Dec 15, 2020

it's nice cleanup for modules/setting/repository.go too ...

Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update cheat sheet and app.example.ini (adding same comment there)

@techknowlogick
Copy link
Member Author

@silverwind thanks for reminder. I have now update docs.

@silverwind
Copy link
Member

Still missing from app.example.ini, just copy the text from the cheat sheet.

@techknowlogick
Copy link
Member Author

@silverwind ah yes, I've also added in one unrelated part of docs too as it was empty and next to ROOT so it was easy enough (although I could include it in separate PR if needed)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2020
@techknowlogick techknowlogick merged commit 88b585c into go-gitea:master Dec 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/distribution This PR changes something about the packaging of Gitea type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snap packge pre-seeds /var/snap/gitea/$version/ in install page breaking snap updates
5 participants