Skip to content

log error when login failed #13903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2020
Merged

log error when login failed #13903

merged 2 commits into from
Dec 8, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 8, 2020

As title.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020 •
edited
Loading

Codecov Report

Merging #13903 (43de185) into master (abb9cff) will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13903      +/-   ##
==========================================
+ Coverage   42.13%   42.21%   +0.07%     
==========================================
  Files         709      709              
  Lines       77187    77184       -3     
==========================================
+ Hits        32526    32583      +57     
+ Misses      39311    39227      -84     
- Partials     5350     5374      +24
Impacted Files Coverage Δ
routers/user/auth.go 12.04% <50.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
services/pull/check.go 49.63% <0.00%> (-1.46%) ⬇️
services/mirror/mirror.go 15.78% <0.00%> (-1.11%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
modules/git/repo.go 45.72% <0.00%> (-0.51%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb9cff...c21de2a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 8, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@6543 6543 merged commit 6a37036 into go-gitea:master Dec 8, 2020
@lunny lunny deleted the lunny/login_error branch December 9, 2020 09:31
lunny added a commit to lunny/gitea that referenced this pull request Dec 9, 2020
@lunny @techknowlogick
log error when login failed (go-gitea#13903)
5437913 
Co-authored-by: techknowlogick <[email protected]>
@lunny lunny mentioned this pull request Dec 9, 2020
Merged
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 9, 2020
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Dec 9, 2020
techknowlogick added a commit that referenced this pull request Dec 9, 2020
@lunny @techknowlogick @6543
log error when login failed (#13903) (#13913)
5cdffc2 
Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @techknowlogick @6543 @GiteaBot