Skip to content

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Dec 3, 2020

Fixes #13762

This fixes the "Quote Reply" button on the code review diff page.

I also noticed the focusing of the text area wasn't working for the "Quote Reply" as well as "Edit". Something else is stealing the focus. I tried to work around that with event.stopPropagation() at first, but that caused other issues. Once I wrapped the focus code in a setTimeout(..., 0) it started working. Might not be the cleanest solution?

@6543 6543 added the type/bug label Dec 3, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 3, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 3, 2020
@silverwind
Copy link
Member

Something else is stealing the focus

Is there a autofocus element on the page? Also, you can try logging document.activeElement in the browser console to find the current focused element.

@jpraet jpraet force-pushed the 13762-quote-reply branch from 0d40327 to f104773 Compare December 5, 2020 12:36
@codecov-io
Copy link

codecov-io commented Dec 5, 2020

Codecov Report

Merging #13830 (ef87733) into master (6bdcacd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13830      +/-   ##
==========================================
+ Coverage   42.13%   42.16%   +0.02%     
==========================================
  Files         708      708              
  Lines       77193    77193              
==========================================
+ Hits        32523    32545      +22     
+ Misses      39318    39298      -20     
+ Partials     5352     5350       -2     
Impacted Files Coverage Δ
modules/queue/workerpool.go 58.77% <0.00%> (-3.27%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
services/pull/pull.go 40.19% <0.00%> (-0.50%) ⬇️
models/error.go 38.66% <0.00%> (+0.48%) ⬆️
modules/git/repo.go 46.23% <0.00%> (+0.50%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
models/issue_comment.go 45.46% <0.00%> (+1.96%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdcacd...ef87733. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@6543 6543 merged commit 4d66ee1 into go-gitea:master Dec 8, 2020
@6543
Copy link
Member

6543 commented Dec 8, 2020

@jpraet would be nice if you send a backport

@6543 6543 added the backport/done All backports for this PR have been created label Dec 8, 2020
@6543
Copy link
Member

6543 commented Dec 8, 2020

-> #13898

zeripath pushed a commit that referenced this pull request Dec 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
@jpraet jpraet deleted the 13762-quote-reply branch January 22, 2021 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote reply on code review comment does not work
6 participants