Skip to content

Use chronological commit order in default squash message #13696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Use chronological commit order in default squash message #13696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a297e4
Use chronological commit order in default squash message (#13661)
jpraet Nov 22, 2020
ab5661c
Merge branch 'master' into 13661-chronological-commit-messages
jpraet Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions services/pull/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,8 @@ func GetCommitMessages(pr *models.PullRequest) string {
authorsMap := map[string]bool{}
authors := make([]string, 0, list.Len())
stringBuilder := strings.Builder{}
element := list.Front()
// commits list is in reverse chronological order
element := list.Back()
for element != nil {
commit := element.Value.(*git.Commit)

Expand All @@ -581,7 +582,7 @@ func GetCommitMessages(pr *models.PullRequest) string {
authors = append(authors, authorString)
authorsMap[authorString] = true
}
element = element.Next()
element = element.Prev()
}

// Consider collecting the remaining authors
Expand Down