Skip to content

Fix issue/pull request list assignee filter #13647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix issue/pull request list assignee filter #13647

merged 3 commits into from
Nov 19, 2020

Conversation

khmarbaise
Copy link
Member

@khmarbaise khmarbaise commented Nov 19, 2020 •
edited by techknowlogick
Loading

  • The URL contains all the time the assignee in cases
    where once a type has been selected.

Signed-off-by: Karl Heinz Marbaise [email protected]

@khmarbaise
Fixes go-gitea#13641 - Filtering in Pull Request kept all the time.
389b50b 
 - The URL contains all the time the assignee in cases
   where once a type has been selected.

Signed-off-by: Karl Heinz Marbaise <[email protected]>
@khmarbaise
Followup Fixes go-gitea#13641 - Filtering in Pull Request kept all th…
95e7b51 
…e time.

 - The URL contains all the time the assignee in cases
   where once a type has been selected.
 - The same behaviour was observed issues viewed via milestones.

Signed-off-by: Karl Heinz Marbaise <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #13647 (95e7b51) into master (ad2a288) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13647      +/-   ##
==========================================
- Coverage   42.20%   42.11%   -0.09%     
==========================================
  Files         697      697              
  Lines       76577    76579       +2     
==========================================
- Hits        32316    32250      -66     
- Misses      38960    39048      +88     
+ Partials     5301     5281      -20
Impacted Files Coverage Δ
routers/repo/issue.go 37.19% <0.00%> (-0.05%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-8.34%) ⬇️
models/issue_comment.go 45.46% <0.00%> (-7.26%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
modules/notification/base/null.go 74.28% <0.00%> (-2.86%) ⬇️
modules/notification/notification.go 83.92% <0.00%> (-2.68%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2a288...95e7b51. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2020
@jolheiser
Copy link
Member

ping lgtm

@jolheiser jolheiser merged commit 702e82d into go-gitea:master Nov 19, 2020
@jolheiser
Copy link
Member

Please send backport to release/v1.13 🙂

@jolheiser jolheiser added this to the 1.14.0 milestone Nov 19, 2020
@jolheiser jolheiser changed the title Fixes #13641 - Filtering in Pull Request kept all the time. Fix issue/pull request list assignee filter Nov 19, 2020
@khmarbaise
Copy link
Member Author

Please send backport to release/v1.13 🙂

does this mean I should create another PR against v1.13 branch?

@techknowlogick
Copy link
Member

does this mean I should create another PR against v1.13 branch?

Yup, a cherrypick would do.

For sake of convenience I've created a copy-paste you could use:

git remote add upstream [email protected]:go-gitea/gitea.git
git fetch upstream
git checkout upstream/release/v1.13 -b backport-13647
git cherry-pick 702e82d
git push origin backport-13647

@6543
Copy link
Member

6543 commented Nov 19, 2020 •
edited
Loading

backport: #13651

khmarbaise added a commit to khmarbaise/gitea that referenced this pull request Nov 19, 2020
@khmarbaise
Fix issue/pull request list assignee filter (go-gitea#13647)
8df7ffb 
* Fixes go-gitea#13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.

Signed-off-by: Karl Heinz Marbaise <[email protected]>

* Followup Fixes go-gitea#13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.
 - The same behaviour was observed issues viewed via milestones.

Signed-off-by: Karl Heinz Marbaise <[email protected]>
@khmarbaise khmarbaise mentioned this pull request Nov 19, 2020
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Nov 19, 2020
jolheiser pushed a commit that referenced this pull request Nov 19, 2020
@khmarbaise
Fix issue/pull request list assignee filter (#13647) (#13651)
ef7a528 
* Fixes #13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.

Signed-off-by: Karl Heinz Marbaise <[email protected]>

* Followup Fixes #13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.
 - The same behaviour was observed issues viewed via milestones.

Signed-off-by: Karl Heinz Marbaise <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@khmarbaise @codecov-io @jolheiser @techknowlogick @6543 @GiteaBot