Delete tag API

[jolheiser]

Resolves #12913

Allows deletion of tags via API, but only if they are not attached to a release. If a release is attached, the user will have to call the API to delete the release, then call this API.

I considered allowing a query parameter or request body with the delete release API, however from my cursory searches it seems as though both would be undefined behavior with the DELETE method, so instead I opted for this approach.

cc @6543

[6543]

    release_test.go:59: 
        	Error Trace:	release_test.go:59
        	            				release_test.go:86
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 3
        	Test:       	TestCreateRelease

    release_test.go:59: 
        	Error Trace:	release_test.go:59
        	            				release_test.go:95
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 3
        	Test:       	TestCreateReleasePreRelease


    release_test.go:59: 
        	Error Trace:	release_test.go:59
        	            				release_test.go:104
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 3
        	Test:       	TestCreateReleaseDraft

[jolheiser]

Hah, that's what I get for running only specific #Tests locally.

[codecov-io]

Codecov Report

Merging #13358 into master will increase coverage by 0.00%.
The diff coverage is 55.55%.

@@           Coverage Diff           @@
##           master   #13358   +/-   ##
=======================================
  Coverage   42.14%   42.15%           
=======================================
  Files         690      690           
  Lines       75871    75888   +17     
=======================================
+ Hits        31975    31988   +13     
+ Misses      38668    38659    -9     
- Partials     5228     5241   +13     

Impacted Files	Coverage Δ
modules/context/api.go	75.22% <ø> (ø)
routers/api/v1/repo/release_tags.go	53.57% <46.66%> (-7.97%)	⬇️
routers/api/v1/api.go	79.50% <100.00%> (+0.05%)	⬆️
modules/indexer/stats/db.go	52.17% <0.00%> (-8.70%)	⬇️
modules/git/utils.go	73.77% <0.00%> (-3.28%)	⬇️
modules/charset/charset.go	73.03% <0.00%> (-2.25%)	⬇️
services/gitdiff/gitdiff.go	67.39% <0.00%> (-1.99%)	⬇️
modules/git/repo.go	46.19% <0.00%> (-1.53%)	⬇️
services/pull/check.go	51.82% <0.00%> (-0.73%)	⬇️
services/pull/pull.go	40.78% <0.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a5bb...dd0fa25. Read the comment docs.

[noerw]

Did this make it into v1.13.0? Merge date lets me think so, but milestone says otherwise..

[lunny]

You should compare merge date with v1.13.0-rc1 but not v1.13.0