Disable all mirror feature elements when DISABLE_MIRRORS is enabled

[pboguslawski]

Parameter DISABLE_MIRRORS should disable all elements of
mirroring feature (i.e. filters in UI, updating cron job)
not just creating new mirrors. This mod fixes it and still
allows exiting mirrors to be converted to regular repos when
DISABLE_MIRRORS=true.

If one need disabling only new mirror creation, should
create mod with separate parameter like DISABLE_MIRROR_CREATE.

Fixes: a6fd2f2
Author-Change-Id: IB#1105104

[6543]

I was thining about DISABLE_MIRRORS=true|create|false but this would complicate settings code ... so not a good idear

@pboguslawski this pull remove "disable mirror creation" and add a new feature ... can you add DISABLE_MIRROR_CREATE too so this pull will only add a feature :)

[pboguslawski]

DISABLE_MIRRORS should do what it means - disable whole mirroring stuff not just creation of new repos (so this may be treated as bug in master I think). I don't see any point in introducing separate DISABLE_MIRROR_CREATE parameter (overconfiguration?) but please feel free to add it if you need it.

[silverwind]

Can we just not render this field instead of hiding?

[pboguslawski]

Was not sure if lack of elements in UI won't break backend (in case lack of variable in post will break something else). Feel free to remove rendering if you're sure it won't hurt.

[silverwind]

Was not sure if lack of elements in UI won't break backend (in case lack of variable in post will break something else). Feel free to remove rendering if you're sure it won't hurt

A missing optional parameter must not break this and if it does, it needs to be fixed in the PR that removed it (this one).

Also there should be a server-side check to reject the parameter to prevent spoofing. It might already be there, haven't checked.

[pboguslawski]

A missing optional parameter must not break this and if it does, it needs to be fixed in the PR that removed it (this one).

This PR only hides stuff and is backward compatible (same data is send to backend as before). It you need more changes feel free do extend this PR.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

[pboguslawski]

Replaced with #18527.